-
Notifications
You must be signed in to change notification settings - Fork 2.1k
add workflow vsphere-upi-disconnected-sdn-workers-rhcos-rhel8 #31841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow vsphere-upi-disconnected-sdn-workers-rhcos-rhel8 #31841
Conversation
|
/retest |
1 similar comment
|
/retest |
|
@jinyunma @jianlinliu Could you help take a look the error ? |
@lihongan for disconnected profile, cluster_profile should use |
0a89e5d to
665e103
Compare
|
/retest |
|
@lihongan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @jianlinliu |
| steps: | ||
| cluster_profile: vsphere | ||
| workflow: cucushift-installer-rehearse-vsphere-ipi-sdn | ||
| cluster_profile: vsphere-discon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a dedicated test for vsphere-discon cluster_profile in the 4.12.yaml just like what we did in 4.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is okay for this PR. We can file another PR to follow up that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion! We can add that in next PR, just keep this one for disconnected profile and add another one for non-disconnected.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianlinliu, lihongan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lihongan: Updated the following 2 configmaps:
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.